[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added a comment.

A drive-by comment...



================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135
+         Params.positions.size());
+    Reply(llvm::make_error<LSPError>("failed to decode request",
+                                     ErrorCode::InvalidRequest));
----------------
This should be `return Reply(...)`, right?
Especially bad if `positions` is empty as we attempt to read the first element right away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67720/new/

https://reviews.llvm.org/D67720