[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 18 05:07:04 PDT 2019


aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/google-objc-require-category-method-prefixes.rst:41
+
+.. option:: ExpectedPrefixes
+
----------------
stephanemoore wrote:
> aaron.ballman wrote:
> > stephanemoore wrote:
> > > This option seems to describe a list of class prefixes that are whitelisted. If that is the case, perhaps `WhitelistedPrefixes` or `WhitelistedClassPrefixes` would be a better name for the option? WDYT?
> > No, please. We should try to avoid "white" and "black" lists in favor of more descriptive terms with less social connotations. I'd be fine with `ExpectedClassPrefixes`, `AllowedPrefixes`, `KnownPrefixes`, etc.
> Makes sense. Would `ExemptClassPrefixes` work?
I think that'd be a great name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65917/new/

https://reviews.llvm.org/D65917





More information about the cfe-commits mailing list