[PATCH] D67584: [Support] Replace function with function_ref in writeFileAtomically. NFC
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 18 01:49:15 PDT 2019
ilya-biryukov reopened this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Ah, the tests fail to compile because we now have an overload where the only difference is `function_ref` vs `StringRef`.
This works fine with `std::function`, STL probably ensures the conversions from `StringRef` to `std::functtion` fail and `function_ref` will only fail at constructor instantiation time.
I'll keep this open for now, will see if it's feasible to make `function_ref` similar to `std::function` in that case.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67584/new/
https://reviews.llvm.org/D67584
More information about the cfe-commits
mailing list