[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 18 00:48:26 PDT 2019
hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/SourceCode.cpp:256
+
SourceLocation getBeginningOfIdentifier(const Position &Pos,
const SourceManager &SM,
----------------
the function name doesn't match what it does now, considering a new name for it, `getBeginningOfIdentifierOrOverloadedOperator` seems too verbose, maybe just `getBeginning`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67695/new/
https://reviews.llvm.org/D67695
More information about the cfe-commits
mailing list