[PATCH] D67559: [Sema] Split of versions of -Wimplicit-{float,int}-conversion for Objective-C BOOL

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 17 14:11:44 PDT 2019


erik.pilkington marked an inline comment as done.
erik.pilkington added inline comments.


================
Comment at: clang/test/Sema/objc-bool-constant-conversion-fixit.m:37
+
+  b = 1 ? 2 : 3;
+  // CHECK: b = 1 ? 2 ? YES : NO : 3 ? YES : NO;
----------------
aaron.ballman wrote:
> What about:
> ```
> b = 1 ? (2 ? 3 : 4) : 5;
> ```
> Will it YES/NO all the way down?
Yeah, we produce the following for this:

`b = 1 ? (2 ? 3 ? YES : NO : 4 ? YES : NO) : 5 ? YES : NO;`

Not pretty, but not incorrect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67559/new/

https://reviews.llvm.org/D67559





More information about the cfe-commits mailing list