[PATCH] D67590: Properly ignore mismatched exception specifiers in MSVC Compat mode.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 17 08:19:46 PDT 2019


thakis added a comment.

In D67590#1672691 <https://reviews.llvm.org/D67590#1672691>, @zahen wrote:

> Is there any interest in supporting the cl.exe flag `/permissive-`?  I considered a hard error on mismatched exception specifier in clang-cl a feature, not a bug.  If msvc compat mode respected that flag this could continue to be an error with that flag set (and upgraded strictness in other cases).


Does `/permissive-` in cl.exe turn this specific thing into an error? If not, we don't want to add this under that flag.

You can always use `-Werror=microsoft-exception-spec` to turn this into an error.

This behavior is necessary to parse system headers, and the general strategy for system headers is "accept enough to be able to parse system headers, but emit a warning". https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ3oYRq0/edit#slide=id.p has some more words on this (slides 26/27).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67590/new/

https://reviews.llvm.org/D67590





More information about the cfe-commits mailing list