[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 17 05:42:06 PDT 2019


hokein added a comment.

In D67651#1672403 <https://reviews.llvm.org/D67651#1672403>, @kadircet wrote:

> this one is actually specific to vardecl's and has a pending fix in D66872 <https://reviews.llvm.org/D66872>
>
> I would rather wait for it to land, instead of adding another branch. WDYT?


fair enough, didn't notice that fix before, the testcase here probably doesn't work after that patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67651/new/

https://reviews.llvm.org/D67651





More information about the cfe-commits mailing list