r371969 - Change signature of __builtin_rotateright64 back to unsigned

[Hans Wennborg via cfe-commits]

Merged to release_90 in r372100.

On Mon, Sep 16, 2019 at 11:50 AM Karl-Johan Karlsson via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Author: karka
> Date: Mon Sep 16 02:52:23 2019
> New Revision: 371969
>
> URL: http://llvm.org/viewvc/llvm-project?rev=371969&view=rev
> Log:
> Change signature of __builtin_rotateright64 back to unsigned
>
> The signature of __builtin_rotateright64 was by misstake changed from
> unsigned to signed in r360863, this patch will change it back to
> unsigned as intended.
>
> This fixes pr43309
>
> Reviewers: efriedma, hans
>
> Reviewed By: hans
>
> Differential Revision: https://reviews.llvm.org/D67606
>
> Modified:
>     cfe/trunk/include/clang/Basic/Builtins.def
>     cfe/trunk/test/CodeGen/avr-builtins.c
>
> Modified: cfe/trunk/include/clang/Basic/Builtins.def
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Builtins.def?rev=371969&r1=371968&r2=371969&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/Builtins.def (original)
> +++ cfe/trunk/include/clang/Basic/Builtins.def Mon Sep 16 02:52:23 2019
> @@ -461,7 +461,7 @@ BUILTIN(__builtin_rotateleft64, "UWiUWiU
>  BUILTIN(__builtin_rotateright8, "UcUcUc", "nc")
>  BUILTIN(__builtin_rotateright16, "UsUsUs", "nc")
>  BUILTIN(__builtin_rotateright32, "UZiUZiUZi", "nc")
> -BUILTIN(__builtin_rotateright64, "UWiUWiWi", "nc")
> +BUILTIN(__builtin_rotateright64, "UWiUWiUWi", "nc")
>
>  // Random GCC builtins
>  BUILTIN(__builtin_constant_p, "i.", "nctu")
>
> Modified: cfe/trunk/test/CodeGen/avr-builtins.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/avr-builtins.c?rev=371969&r1=371968&r2=371969&view=diff
> ==============================================================================
> --- cfe/trunk/test/CodeGen/avr-builtins.c (original)
> +++ cfe/trunk/test/CodeGen/avr-builtins.c Mon Sep 16 02:52:23 2019
> @@ -1,5 +1,9 @@
>  // RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s
>
> +// Check that the parameter types match. This verifies pr43309.
> +// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversion -verify %s
> +// expected-no-diagnostics
> +
>  unsigned char bitrev8(unsigned char data) {
>      return __builtin_bitreverse8(data);
>  }
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits