[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

James Clarke via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 16 09:24:54 PDT 2019


jrtc27 added inline comments.


================
Comment at: llvm/trunk/include/llvm/IR/DiagnosticInfo.h:79
+  DK_FirstPluginKind,
+  DK_MisExpect
 };
----------------
Is this not going to clash with the first caller to `getNextAvailablePluginDiagnosticKind`? `DK_FirstPluginKind` is special and shouldn't have anything after it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66324/new/

https://reviews.llvm.org/D66324





More information about the cfe-commits mailing list