[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

Mon Sep 16 08:00:53 PDT 2019

lebedev.ri added a comment.

Some thoughts:

1. Docs missing
2. How does this play with C++17 aligned new? Assuming compiler/library support for that isn't broken ('bye, OSX!', ?), i'm not sure why it would be UB for C++17, see https://godbolt.org/z/kwxRbu vs https://godbolt.org/z/om-bR2
3. I'm not sure what's `getCharAlign()` has to do with anything here? You want to check the alignment requirement against the `__STDCPP_DEFAULT_NEW_ALIGNMENT__` (i don't recall how to get it inside of clang) i would think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67545/new/

https://reviews.llvm.org/D67545