[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 15 12:05:17 PDT 2019


lebedev.ri added a comment.

Forgot the most important question.
Right now this will fire on every single struct.
But it won't matter unless the alignment/size actually matters, and most often that will happen when you have e.g. a vector of such structs.
What i'm asking is - should this be more picky, and complain only about the cases where this matters?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66564/new/

https://reviews.llvm.org/D66564





More information about the cfe-commits mailing list