[PATCH] D67585: [clang] [cmake] Make building dylib optional

[Chris Bieneman via Phabricator via cfe-commits]

beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.

Please no. You don’t need to build the library. ‘check-clang’ doesn’t depend on it, so it should not impact your build and test cycles. We want it included in the ‘all’ target for every possible configuration so that it gets tested and not broken as frequently as the LLVM dylib target has in the past.

If you don’t want to link it you can avoid linking it by running the ‘check’ targets instead of building ‘all’. In general, I believe we need to reduce the number of options for configuring the LLVM build. The build system has reached a point where the number of possible configurations is so massive that the build system is fragile and becoming more challenging to modify.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67585/new/

https://reviews.llvm.org/D67585