[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: clang/lib/AST/Decl.cpp:3334
 /// For an inline function definition in C, or for a gnu_inline function
 /// in C++, determine whether the definition will be externally visible.
 ///
----------------
As this method only expects to be called for `gnu_inline` in C++ mode ("nline function definition in C, or for a gnu_inline function in C++" from the comment), and we're changing the C++ case to a plain `if (C++) return false;`, one could also consider updating the caller and making this method only be used for C mode, but maybe that should be left as a separate refactoring step (if it's worth doing at all)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67414/new/

https://reviews.llvm.org/D67414