[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 12 14:25:41 PDT 2019


Szelethus added a comment.

In D67420#1668474 <https://reviews.llvm.org/D67420#1668474>, @NoQ wrote:

> It's not that `AnalyzerOptions` is //necessary// to construct this, it's more like //sufficient//.


*sudden enlightenment*

Ah, okay, right, I'm a dummie, I think I got what's happening here! :) In that case, the idea sounds great. I'll take a second look on the code later (I have a feeling that we should delete the default ctor of `PathDiagnosticConsumerOptions`, etc), but I'm just a tad too tired atm :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67420/new/

https://reviews.llvm.org/D67420





More information about the cfe-commits mailing list