[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 12 13:38:06 PDT 2019


nickdesaulniers added inline comments.


================
Comment at: lib/AST/Decl.cpp:3283
 
   if (Context.getLangOpts().CPlusPlus)
     return false;
----------------
I would have thought the existing case here would handle your change.  If it doesn't, why not?  Should your change also remove this (essentially moving it earlier)?


================
Comment at: lib/AST/Decl.cpp:3381
   // The rest of this function is C-only.
   assert(!Context.getLangOpts().CPlusPlus &&
          "should not use C inline rules in C++");
----------------
Ditto.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67414/new/

https://reviews.llvm.org/D67414





More information about the cfe-commits mailing list