[PATCH] D67491: Removed some questionable default arguments from setters

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 12 04:30:12 PDT 2019


gribozavr created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

They can be confusing -- what does it mean to call a setter without a
value? Also, some setters, like `setPrintTemplateTree` had `false` as
the default value!

The callers are largely not using these default arguments anyway.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67491

Files:
  clang/include/clang/Basic/Diagnostic.h
  clang/lib/ARCMigrate/ARCMT.cpp
  clang/lib/Frontend/FrontendActions.cpp
  clang/lib/Sema/Sema.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67491.219882.patch
Type: text/x-patch
Size: 3977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190912/e097f23e/attachment.bin>


More information about the cfe-commits mailing list