[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

Sorry for the long delay!

I have one question about a slighty different code constellation.

  std::optional<std::array<int, 4>> my_array;
  
  for(int i = 0; i < 42; ++i)
      (*my_array)[i] = 42;

Will this be fixed properly?

  for(int i = 0; i < 42; ++i)
      gsl::at(*my_array, i) = 42;

If the braces in `(*my_array)` would be moved into the function that is ok as well.

This is just of general interest and should not block this patch in my opinion, as its a different bug.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56661/new/

https://reviews.llvm.org/D56661