[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added a comment.

> Hm, I was not aware of this Linux linker feature, thanks a lot for the explanation! I see only one problem with using it as a replacement for the begin/end objects – it looks like `__start_name`/`__stop_name` symbols are created with `default` visibility instead of `hidden`. I guess it will cause problems for offload programs that use shared libraries because DSO’s `__start_name`/`__stop_name` symbols will be preempted by the executable’s symbols and that is not what we want. Is there any way to change this behavior?

Declaring the symbol as `__attribute__((__visibility__("hidden")))` just works as far as I can tell. The linker still provides the right definition, objdump says it's hidden.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64943/new/

https://reviews.llvm.org/D64943