[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

Wed Sep 11 13:27:32 PDT 2019

sdmitriev added a comment.

In D64943#1666636 <https://reviews.llvm.org/D64943#1666636>, @JonChesterfield wrote:

> I'm not sure copying the crtbegin/crtend mechanism from the early days of C runtime is ideal. Since the data is stored in a common section anyway, please could we rename it to __omp_offloading_entries in which case the linker will provide start/end symbols automatically?

Well, I never said that it is an ideal solution, but it is a known mechanism that works well in many cases and can also be reused for the offloading entry table.
I do not fully understand your suggestion for renaming entries section, how it will help with providing start/end symbols for the entries. Can you please provide more details?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64943/new/

https://reviews.llvm.org/D64943