[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

[Narayanaswamy, Ravi via cfe-commits]

Microsoft linker does not support linker script. 
We need to solution that works with all linkers.   The begin/end is supported by most linker of interest.

-----Original Message-----
From: Jon Chesterfield via Phabricator [mailto:reviews at reviews.llvm.org] 
Sent: Wednesday, September 11, 2019 12:21 PM
To: Dmitriev, Serguei N <serguei.n.dmitriev at intel.com>; hfinkel at anl.gov; a.bataev at hotmail.com; Narayanaswamy, Ravi <ravi.narayanaswamy at intel.com>; jdoerfert at anl.gov; gheorghe-teod.bercea at ibm.com; Rokos, Georgios <georgios.rokos at intel.com>
Cc: lebedev.ri at gmail.com; jonathanchesterfield at gmail.com; Zakharin, Vyacheslav P <vyacheslav.p.zakharin at intel.com>; sandoval at cray.com; openmp-commits at lists.llvm.org; cfe-commits at lists.llvm.org; mgorny at gentoo.org; zhang.guansong at gmail.com; mgrang.1234 at gmail.com; tra at google.com; zturner at roblox.com; peter.waller at arm.com
Subject: [PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment.

In D64943#1666673 <https://reviews.llvm.org/D64943#1666673>, @ABataev wrote:

> In D64943#1666658 <https://reviews.llvm.org/D64943#1666658>, @JonChesterfield wrote:
>
> > > OpenMP linker script is known to cause problems for gold and lld linkers on Linux and it will also cause problems for Windows enabling in future
> >
> > What are the known problems with the linker script? I'm wondering if they can be resolved without the overhead of introducing a new tool.
>
>
> They just do not support linker script. And, thus, cannot be used for offloading. Only `ld` supports it.


In what respect? I've used linker scripts with both gold and lld, and both instances of --help text claim to support them. In the case of lld, a very complicated script hit a few internal errors, but I believe they've all been fixed since.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64943/new/

https://reviews.llvm.org/D64943