[PATCH] D67454: Start porting ivfsoverlay tests to Windows

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 11:39:18 PDT 2019


rnk created this revision.
rnk added a reviewer: amccarth.
Herald added a subscriber: arphaman.
Herald added a project: clang.

Part of PR43272, the changes are:

1. Use @ as the sed pattern delimiter instead of : so that the drive

letter in lit substitutions isn't an issue.

2. Use the %/t and %/S substitutions to get paths with forward slashes

to work around string quoting issues in the yaml file.

3. Replace REQUIRES:shell with XFAIL:windows. These tests should pass on

Windows, but do not for reasons that are not yet understood. We would
like to know if they pass unexpectedly.

I was able to remove the XFAILs from two tests, since they already pass
with my sed fix:

  clang/test/VFS/module_missing_vfs.m
  clang/test/VFS/test_nonmodular.c


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67454

Files:
  clang/test/Index/index-module-with-vfs.m
  clang/test/Modules/crash-vfs-ivfsoverlay.m
  clang/test/Modules/double-quotes.m
  clang/test/Modules/framework-public-includes-private.m
  clang/test/VFS/external-names.c
  clang/test/VFS/framework-import.m
  clang/test/VFS/implicit-include.c
  clang/test/VFS/include-mixed-real-and-virtual.c
  clang/test/VFS/include-real-from-virtual.c
  clang/test/VFS/include-virtual-from-real.c
  clang/test/VFS/include.c
  clang/test/VFS/incomplete-umbrella.m
  clang/test/VFS/module-import.m
  clang/test/VFS/module_missing_vfs.m
  clang/test/VFS/real-path-found-first.m
  clang/test/VFS/relative-path.c
  clang/test/VFS/subframework-symlink.m
  clang/test/VFS/test_nonmodular.c
  clang/test/VFS/umbrella-framework-import-skipnonexist.m
  clang/test/VFS/vfsroot-include.c
  clang/test/VFS/vfsroot-module.m
  clang/test/VFS/vfsroot-with-overlay.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67454.219753.patch
Type: text/x-patch
Size: 17328 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190911/0e2dfe02/attachment-0001.bin>


More information about the cfe-commits mailing list