[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 10 22:14:16 PDT 2019


shafik added inline comments.


================
Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118
+      template <class T>
+      constexpr T X;
+      )";
----------------
shafik wrote:
> Note this is not well-formed b/c it is not initialized, [see godbolt](https://godbolt.org/z/8xvFwh)
But it would be ok combined w/ a specialization:

```
template <>
constexpr int X<int> = 0;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66951/new/

https://reviews.llvm.org/D66951





More information about the cfe-commits mailing list