[PATCH] D47956: [MS] Consder constexpr globals to be inline, as in C++17

Tue Sep 10 17:26:54 PDT 2019

rnk added a comment.

In D47956#1138555 <https://reviews.llvm.org/D47956#1138555>, @rnk wrote:

> In D47956#1138521 <https://reviews.llvm.org/D47956#1138521>, @rsmith wrote:
>
> > Can we now remove the corresponding MSVC-specific hacks elsewhere (eg, `ASTContext::isMSStaticDataMemberInlineDefinition`), or do we still need those for `const`-but-not-`constexpr` static data members?
>
>
> We should be able to do that, but unfortunately it drastically changes the diagnostics we emit, as you can see from the tortured ifdefs in my test case updates. I gave up before attempting it.

Coming back to this a year later, I think I got confused. This patch is good to go, but I never landed it because I wanted to implement Richard's comment. I guess I'll go forward with this and see what breaks. The main thing seems to be that now applying dllexport to some static data members outside the class body becomes a warning instead of a hard error. So, we should be more accepting with this than we were previously.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47956/new/

https://reviews.llvm.org/D47956