[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

Mon Sep 9 15:01:50 PDT 2019

RKSimon added a comment.

In D64146#1663867 <https://reviews.llvm.org/D64146#1663867>, @nand wrote:

> I am providing definitions in the C++ file - the problem is that they are not available in the header before the extern declaration. The methods are available at the site of the extern definition.
>  gcc and clang accept this,  so does Visual Studio 2019. This feels like an incorrect implementation of extern templates in Visual Studio?
>
> I see two ways to proceed: move everything into a header (would like to avoid this) or silence the warning on VC++ (not great either). 
>  Is there a better way? Which option is less bad from these two?

I think I'm missing something - for instance when I search the patch for "visitIndirectMember", all I get is this in ByteCodeExprGen.h:

  bool visitIndirectMember(const BinaryOperator *E);

I don't see it in ByteCodeExprGen.cpp

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64146/new/

https://reviews.llvm.org/D64146