[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

[Luboš Luňák via Phabricator via cfe-commits]

llunak added a comment.

In D65371#1659929 <https://reviews.llvm.org/D65371#1659929>, @dblaikie wrote:

> A test case would be good (in the clang/test directory - probably near/in the other tests for -frewrite-includes)


Done.

> And does the same bug occur for other preprocessor-related warnings? Maybe it's not practical to disable them all this way & there should be a different solution? (or maybe we shouldn't fix these and users can pass -w to disable warnings when using -frewrite-includes?)

I've never seen any other warning from -frewrite-includes besides -Wunused-macros. Given that I use and more or less maintain Icecream, which uses -frewrite-includes for distributed builds, I'd say any other warnings there either don't exist or are very rare (which rather makes sense, given that -frewrite-includes only does limited macro expansion when analysing the input and that's about it). Given that, I'd prefer not to disable warnings globally - they are unlikely to show up, if they do, they can hopefully be handled individually, but on the other hand maybe Clang one day gets warnings about #include or similar that would be a pity to miss when using -rewrite-includes.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65371/new/

https://reviews.llvm.org/D65371