[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 9 07:00:25 PDT 2019


tstellar added inline comments.


================
Comment at: clang/tools/libclang/CMakeLists.txt:115
+clang_target_link_libraries(libclang
+  PRIVATE
+  ${CLANG_LIB_DEPS}
----------------
aaronpuchert wrote:
> This might not be correct for static builds, I think we need `INTERFACE` here.
This patch looks OK to me, but you should find someone with more CMake knowledge to answer this question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67321/new/

https://reviews.llvm.org/D67321





More information about the cfe-commits mailing list