[PATCH] D67341: [clangd] Simplify semantic highlighting visitor

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 9 01:36:15 PDT 2019


ilya-biryukov created this revision.
ilya-biryukov added a reviewer: hokein.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.

- Functions to compute highlighting kinds for things are separated from the ones that add highlighting tokens. This keeps each of them more focused on what they're doing: getting locations and figuring out the kind of the entity, correspondingly.

- Less special cases in visitor for various nodes.

As a side effect, we started to highlight 'auto' for lambdas as having
class type.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D67341

Files:
  clang-tools-extra/clangd/SemanticHighlighting.cpp
  clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67341.219292.patch
Type: text/x-patch
Size: 14240 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190909/6e9d563d/attachment-0001.bin>


More information about the cfe-commits mailing list