[PATCH] D65433: [clangd] DefineInline action availability checks
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 6 18:01:22 PDT 2019
arphaman added a comment.
When fully implemented, will define inline tweak work with C++ methods in classes as well?
E.g.
HEADER:
class Foo { void foo(); }
CPP:
#include "Header.h"
void Foo::foo() {}
becomes:
HEADER:
class Foo { void foo() { } }
CPP:
#include "Header.h"
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:192
+ Intent intent() const override { return Intent::Refactor; }
+ std::string title() const override { return "Inline function definition"; }
+
----------------
Sorry, I'm not really familiar with design of tweaks, so this might be a bad question: Is it possible to change the title of the tweak on a per-TU basis. More specifically, some tweaks might want to have different titles for Objective-C actions compared to their C++ siblings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65433/new/
https://reviews.llvm.org/D65433
More information about the cfe-commits
mailing list