[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data
Leonard Chan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Sep 6 11:11:54 PDT 2019
leonardchan added inline comments.
================
Comment at: clang-tools-extra/clang-misexpect/ClangMisExpect.cpp:77
+ break;
+ llvm_unreachable("Bad Profile Format given to clang-misexpect use one of "
+ "(clang, llvm, csllvm, sample)");
----------------
Nit: llvm_unreackable is unneeded since you cover all `ProfileKind`s here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67253/new/
https://reviews.llvm.org/D67253
More information about the cfe-commits
mailing list