[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

Fri Sep 6 10:07:25 PDT 2019

martong marked 3 inline comments as done.
martong added a comment.

In D66951#1660886 <https://reviews.llvm.org/D66951#1660886>, @balazske wrote:

> OK
>  Probably the `ClassTemplateSpec` can not be handled in liberal way because the AST data structure for template specializations do not allow multiple instances with same argument values?

Yes exactly, that is the case. The implementation holds the specializations in a set, and the key within the set is a hash calculated from the arguments of the specialization.
All specializations are implemented like this, this includes variabletemplatespecializations too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66951/new/

https://reviews.llvm.org/D66951