[PATCH] D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 6 05:31:42 PDT 2019


lebedev.ri added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/readability-magic-numbers.cpp:1
-// RUN: %check_clang_tidy %s readability-magic-numbers %t \
+// RUN: %check_clang_tidy -std=c++14 %s readability-magic-numbers %t \
 // RUN: -config='{CheckOptions: \
----------------
IIRC `%check_clang_tidy` is actually run for every standard, so this decreases test coverage;
just add a c++14-specific test.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67265/new/

https://reviews.llvm.org/D67265





More information about the cfe-commits mailing list