[PATCH] D67264: [clangd] Collect location of macro definition in the ParsedAST

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 6 05:12:07 PDT 2019


hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:104
 // *definitions* in the preamble region of the main file).
 class CollectMainFileMacroExpansions : public PPCallbacks {
   const SourceManager &SM;
----------------
The name doesn't fit into what it does anymore, maybe rename to `CollectMainFileMacroLocations`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67264/new/

https://reviews.llvm.org/D67264





More information about the cfe-commits mailing list