[PATCH] D53238: [Driver] Add -static= to unify -static-{libgcc,libstdc++}

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

In D53238#1660259 <https://reviews.llvm.org/D53238#1660259>, @pirama wrote:

> Does this regress from existing behavior for unused argument warnings?  Currently, `-static-libstdc++ -nostdlib` issues an unused argument warning for `-static-libstdc++`, while AFAICT `-static=c++stdlib -nostdlib` doesn't.
>
> I'm not exactly sure how/where to issue this warning, though.


This change will suppress some unused argument warnings but I'll not call that "regression":)

Various toolchains already do things like:

  Args.ClaimAllArgs(options::OPT_g_Group);
  Args.ClaimAllArgs(options::OPT_emit_llvm);
  Args.ClaimAllArgs(options::OPT_w);

Hexagon and Myriad even do `Args.ClaimAllArgs(options::OPT_static_libgcc);` This diagnostic IMO has very low value.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53238/new/

https://reviews.llvm.org/D53238