[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 16:43:53 PDT 2019


sbc100 added a comment.

Derek, are you saying that `-mexception-handling` is somehow related to `-fno-exceptions`.   What is the relationship?    I wasn't aware this change was related to  `-fno-exceptions`.

`-pthreads`  enabling `-matomics` and `-mbulk-memory`make some sense because each of those low level flags might make sense on its own.   But if `-fwasm-exceptions` only going to enable `-mexception-handling` then I'm not sure I see the point in adding it.  Or is there something else it will enable?   Also, we didn't add `-pthread`, it was pre-existing we we didn't need to justify adding it but rather make it work.

Sorry, I'm not necessarily against this change but I want to avoid adding flags unless there is a clear need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67208/new/

https://reviews.llvm.org/D67208





More information about the cfe-commits mailing list