[PATCH] D67028: Use musttail for variadic method thunks when possible

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 14:47:03 PDT 2019


rnk added a comment.

I think what I said applies to your test case. Basically, in the Itanium C++ ABI, virtual method definitions provide all their thunks as `weak_odr`. We only emit thunks referenced by vtables as an optimization, and they are marked `available_externally`. In your test case, we hit the early return that I linked to, so we don't try to clone, and we don't need to emit an error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67028/new/

https://reviews.llvm.org/D67028





More information about the cfe-commits mailing list