[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 5 12:36:20 PDT 2019


Mordante marked 3 inline comments as done.
Mordante added inline comments.


================
Comment at: clang/test/SemaTemplate/instantiate-incomplete-typo-suggested-error-limit.cpp:1
+// RUN: not %clang -fsyntax-only -std=c++11 -ferror-limit=1 %s 2>&1 | FileCheck %s
+
----------------
aaron.ballman wrote:
> Do you intend to test `%clang_cc1` instead? Can the test be rewritten to use `-verify` rather than `FileCheck`? If the test crashes or asserts, that will cause the test to fail anyway, so it doesn't seem like it needs to `FileCheck`.
As discussed on IRC this is not possible due to the fact there is an error without line number.
`  (frontend): too many errors emitted, stopping now`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64644/new/

https://reviews.llvm.org/D64644





More information about the cfe-commits mailing list