[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002
         false);
     llvm::Constant *Resolver = GetOrCreateLLVMFunction(
         MangledName + ".resolver", ResolverType, GlobalDecl{},
----------------
This Resolver should have the same linkage as below.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3005
         /*ForVTable=*/false);
+    auto Linkage = (FD->isCPUDispatchMultiVersion() || FD->isCPUSpecificMultiVersion())
+        ? llvm::Function::LinkOnceODRLinkage
----------------
I think this can always just be LinkOnceODR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67058/new/

https://reviews.llvm.org/D67058