[PATCH] D67031: [Clang][Bundler] Error reporting improvements

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld added a comment.

Also, there should be a summary of the changes in here.



================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include <memory>
-#include <string>
-#include <system_error>
-#include <vector>
----------------
sdmitriev wrote:
> Hahnfeld wrote:
> > sdmitriev wrote:
> > > Hahnfeld wrote:
> > > > The code still uses (in the order of marked includes)
> > > >  * `std::unique_ptr`
> > > >  * `std::string`
> > > >  * `std::error_code`
> > > >  * `std::vector`,
> > > > so I don't think these lines should be removed. Same goes for `assert` and probably also `cstddef` / `cstdint` (`uint64_t`?)
> > > Right. Restored required system includes.
> > `vector` is still removed which is definitely used. Are you 100% sure that `algorithm` and `cstddef` are not needed?
> I have replaced all uses of vector with SmallVector.
> 
> > Are you 100% sure that algorithm and cstddef are not needed?
> 
> Ok, I will add algorithm and cstddef back:)
If you want to replace `vector` by `SmallVector`, this must be its own revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67031/new/

https://reviews.llvm.org/D67031