[PATCH] D67031: [Clang][Bundler] Error reporting improvements

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 4 11:13:52 PDT 2019


Hahnfeld added inline comments.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include <memory>
-#include <string>
-#include <system_error>
-#include <vector>
----------------
sdmitriev wrote:
> Hahnfeld wrote:
> > The code still uses (in the order of marked includes)
> >  * `std::unique_ptr`
> >  * `std::string`
> >  * `std::error_code`
> >  * `std::vector`,
> > so I don't think these lines should be removed. Same goes for `assert` and probably also `cstddef` / `cstdint` (`uint64_t`?)
> Right. Restored required system includes.
`vector` is still removed which is definitely used. Are you 100% sure that `algorithm` and `cstddef` are not needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67031/new/

https://reviews.llvm.org/D67031





More information about the cfe-commits mailing list