[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 3 22:51:03 PDT 2019


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Yay thanks!!

In my understanding "check" is a feature of the tool, while "checker" is an entity within the tool that implements that feature. In most cases there's no difference, though, so yeah, it's a tradition thing. I generally enjoy being able to say things like "Malloc //checker// (singular!) provides //checks// (plural!) for use-after-free bugs and memory leaks". Also i believe that "check" in `checkPreCall`  is a verb, so yeah, it should be kept.

> a fundamental difference in between the analyzer and clang-tidy

Honestly, i'm much more worried about message capitalization :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67140/new/

https://reviews.llvm.org/D67140





More information about the cfe-commits mailing list