[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 3 14:54:52 PDT 2019


rjmccall added a comment.

Can you prepare an NFC patch with just the changes relating to adding `ObjCPropertyImplDecl::get{Getter,Setter}MethodDecl`?

I don't get why the redeclaration logic is changing.  What happens when a normal method is implemented?  Is that not linked up as a redeclaration?



================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:638
 
-void CodeGenFunction::StartFunction(GlobalDecl GD,
-                                    QualType RetTy,
+void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy,
                                     llvm::Function *Fn,
----------------
Now-spurious style change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66121/new/

https://reviews.llvm.org/D66121





More information about the cfe-commits mailing list