[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.
Shafik Yaghmour via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 3 14:32:44 PDT 2019
shafik added inline comments.
================
Comment at: clang/unittests/AST/ASTImporterVisibilityTest.cpp:343
+ ::testing::Values(
+ std::make_tuple(ExternTypedef, ExternTypedef, ExpectLink),
+ std::make_tuple(ExternTypedef, AnonTypedef, ExpectNotLink),
----------------
I don't have any objections to changing the names `ExpectLink` and `ExpectNotLink` in a subsequent patch but we should update then b/c they are confusing (because they are overloaded terms) and it takes some time to work backwards to understand the intent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64480/new/
https://reviews.llvm.org/D64480
More information about the cfe-commits
mailing list