[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.
    Aaron Ballman via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Tue Sep  3 13:02:57 PDT 2019
    
    
  
aaron.ballman added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:240
+  Arg = Arg->IgnoreImpCasts();
+  if (isa<UnaryOperator>(Arg))
+      Arg = cast<UnaryOperator>(Arg)->getSubExpr();
----------------
The bug claims that this is only for handling negative literals, but this allows any unary operator. Is that intentional? If we're going to allow arbitrary unary operators, why not arbitrary binary operators as well?
Repository:
  rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67084/new/
https://reviews.llvm.org/D67084
    
    
More information about the cfe-commits
mailing list