[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

Jinsong Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 3 10:07:18 PDT 2019


jsji marked 2 inline comments as done.
jsji added inline comments.


================
Comment at: clang/test/CodeGen/builtins-ppc-error.c:78
+void testDSS(int index) {
+  vec_dss(index); //expected-error {{argument to '__builtin_altivec_dss' must be a constant integer}}
+
----------------
wuzish wrote:
> It would be better if add range constraint check at Sema::CheckPPCBuiltinFunctionCall
Good point, Done. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66699/new/

https://reviews.llvm.org/D66699





More information about the cfe-commits mailing list