[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 3 02:47:30 PDT 2019


gribozavr added inline comments.


================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp:5836-5837
       if (VT.getSizeInBits() == 128)
         return std::make_pair(0U, &AArch64::FPR128_loRegClass);
+    case 'y':
+      if (!Subtarget->hasFPARMv8())
----------------
```
AArch64ISelLowering.cpp:5837:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
AArch64ISelLowering.cpp:5837:5: note: insert 'LLVM_FALLTHROUGH;' to silence this warning
AArch64ISelLowering.cpp:5837:5: note: insert 'break;' to avoid fall-through
```

Is the fallthrough intentional?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66302/new/

https://reviews.llvm.org/D66302





More information about the cfe-commits mailing list