[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

Mon Sep 2 11:12:14 PDT 2019

erichkeane added a comment.

In D67058#1654347 <https://reviews.llvm.org/D67058#1654347>, @lebedev.ri wrote:

> Tests missing.
>  Is that what gcc does? I'd personally thought those should be internalized.

GCC doesn't implement CPU dispatch, this is an ICC thing.  ICC uses the Windows behavior on both, but when implementing in Clang we opted to use IFuncs for Linux.  This is troublesome, as it can result in the 'FuncName' symbol not existing (so a separate TU treating this function as an extern function on Linux wouldn't link).

I accept this approach, but need to spend some time tomorrow doing some additional review.

That said, this definitely still needs to be covered by lit tests.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67058/new/

https://reviews.llvm.org/D67058