[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

Mon Sep 2 05:34:05 PDT 2019

gribozavr added inline comments.

================
Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:174
+  ///  This location is used by clients rendering diagnostics.
+  virtual PathDiagnosticLocation getLocation(const SourceManager &SM) const {
+    assert(Location.isValid());
----------------
gribozavr wrote:
> Another location-related method... I guess I would appreciate a more abstract writeup about what BugReport's data model is (in its doc comment).
What I meant by "data model" is a high-level description like this.

A bug report is one instance of a problem found by a checker. It is similar to a warning in Clang.

A bug report has:

- a description which is ...

- a short description (optional), which is ...

- zero or more ranges, which ...

- zero or more fixits, which provide advice about ...

- zero  or more notes, which ...

Each fixit has: ...

Each note has...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66572/new/

https://reviews.llvm.org/D66572