[PATCH] D66862: Make lround builtin constexpr (and others)

[Zoe Carver via Phabricator via cfe-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:9617
+    APFloat FPVal(0.0);
+    APSInt IVal(Info.Ctx.getIntWidth(E->getType()), 0);
+    bool isExact = true;
----------------
rsmith wrote:
> Please use `/*isUnsigned=*/false` for the second argument rather than `0`.
I'm using the default value of `isUnsigned` (false). Do you want me to specify it? The second argument (`0`) is the initial value (which is required). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66862/new/

https://reviews.llvm.org/D66862