[PATCH] D67031: [Clang][Bundler] Error reporting improvements
Sergey Dmitriev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 31 11:03:37 PDT 2019
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:906
+ Msg << ", unknown target triple '" << Triple << "'";
+ reportError(createStringError(errc::invalid_argument, Msg.str() + "."));
}
----------------
MaskRay wrote:
> I think trailing full stop is uncommon in error messages.
Maybe., but all error messages in this tool seem to be consistent in that sense)) Do you suggest removing trailing '.' from all error messages?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67031/new/
https://reviews.llvm.org/D67031
More information about the cfe-commits
mailing list