[PATCH] D67031: [Clang][Bundler] Error reporting improvements [NFC]

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 31 07:57:06 PDT 2019


Hahnfeld added a comment.

This changes error messages, so I'd say it's not NFC.



================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:41-44
-#include <memory>
-#include <string>
-#include <system_error>
-#include <vector>
----------------
The code still uses (in the order of marked includes)
 * `std::unique_ptr`
 * `std::string`
 * `std::error_code`
 * `std::vector`,
so I don't think these lines should be removed. Same goes for `assert` and probably also `cstddef` / `cstdint` (`uint64_t`?)


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67031/new/

https://reviews.llvm.org/D67031





More information about the cfe-commits mailing list